Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix philosphy typo #1

Merged
merged 1 commit into from
Jan 7, 2018
Merged

fix philosphy typo #1

merged 1 commit into from
Jan 7, 2018

Conversation

danawillow
Copy link
Contributor

No description provided.

@danawillow danawillow requested a review from nelsonjr January 6, 2018 00:33
@nelsonjr
Copy link
Contributor

nelsonjr commented Jan 7, 2018

Thank you!

@nelsonjr nelsonjr merged this pull request into GoogleCloudPlatform:master Jan 7, 2018
nat-henderson added a commit that referenced this pull request Mar 8, 2018
This sets up the CI system by which changes can flow from MagicModules down to Terraform. In its current form it only does Terraform, but a major goal is to extend it to all generated repositories.

The code here refers to a handful of docker containers I had to create - one of them has its Dockerfile checked in here, but the rest are built from other, existing repositories. Still working to get my changes to those upstream repos merged, but in the meantime I've built my own versions and am using those.

This isn't all the way done: I've commented out "trigger: true" in a few places here because I don't think this is ready to be fully automated yet. It also currently does all the work in a user's own forks rather than the main repos. I want to review it as-is (since it's approximately the minimum viable proof-of-concept), and I'll try to make smaller changes from here on in.
nat-henderson added a commit that referenced this pull request Jan 2, 2019
modular-magician pushed a commit that referenced this pull request Jan 2, 2019
c2thorn pushed a commit that referenced this pull request May 11, 2020
edwardmedia added a commit that referenced this pull request May 15, 2020
* add descriptions to the schema

* add descriptions to schema

* run go fmt

Co-authored-by: Edward Sun <[email protected]>
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
…#3507)

* add descriptions to the schema

* add descriptions to schema

* run go fmt

Co-authored-by: Edward Sun <[email protected]>
megan07 referenced this pull request in hashicorp/magic-modules Oct 12, 2020
drebes pushed a commit to drebes/magic-modules that referenced this pull request Nov 11, 2020
gfxcc pushed a commit to gfxcc/magic-modules that referenced this pull request Nov 16, 2021
…_url_param_only

* Use url_param_only instead of virtual field
* Rename new field includeMaxPathLength to includeMaxIssuerPathLength for local consistence
SarahFrench pushed a commit that referenced this pull request Sep 26, 2024
Signed-off-by: drfaust92 <[email protected]>
Co-authored-by: karolgorc <[email protected]>
Co-authored-by: Augusto Hidalgo <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Ilia Lazebnik <[email protected]>
Co-authored-by: vijaykanthm <[email protected]>
Co-authored-by: Abhijeet Jha <[email protected]>
Co-authored-by: bcreddy-gcp <[email protected]>
Co-authored-by: Cameron Thornton <[email protected]>
Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Zhenhua Li <[email protected]>
Co-authored-by: Ron Gal <[email protected]>
SarahFrench added a commit that referenced this pull request Sep 26, 2024
ScottSuarez pushed a commit to ScottSuarez/magic-modules that referenced this pull request Oct 8, 2024
shuyama1 pushed a commit to shuyama1/magic-modules that referenced this pull request Nov 22, 2024
Add google_backup_dr_backup_vault datasource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants