Default enable viper #2109
Draft
Default enable viper #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We want to use the metadata-cache.ttl-secs field to represent the metadata-cache ttl and resolve it upfront as opposed to resolving it when needed. We'll follow up with a similar change for the old config too which will allow us to use the old and new configs interchangeably. * Make change to set the enable-empty-managed-folders whenever enable-hns is set.
Resolve stat-cache-max-size-mb ahead of time and use the new value wherever needed as opposed to resolving it when needed
Those warnings will be handled by the deprecation semantics of viper and will be centralized.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2109 +/- ##
==========================================
- Coverage 71.88% 71.86% -0.02%
==========================================
Files 101 102 +1
Lines 11029 11066 +37
==========================================
+ Hits 7928 7953 +25
- Misses 2773 2781 +8
- Partials 328 332 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kislaykishore
force-pushed
the
default-enable-viper
branch
from
1f96a20
to
02c6513
Compare
kislaykishore
force-pushed
the
default-enable-viper
branch
from
02c6513
to
e7c5a81
Compare
kislaykishore
force-pushed
the
default-enable-viper
branch
from
e7c5a81
to
c7b53b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to the issue in case of a bug fix.
NA
Testing details