Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude files from cache based on name #2043

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

siddharthab
Copy link

@siddharthab siddharthab commented Jun 20, 2024

The current logic to assume that files are meant for small random reads
if the first read to them has a non-zero offset, assumes the absence of
file headers at the beginning of the file, and/or the absence of magic
number checks.

The new option to specify such files by regular expression pattern will
allow the users to mark such files as random access only, even when
their headers are fetched first.

Some organization cleanup has also been performed that moves the
cacheFileForRangeRead option to inside the CacheHandler instead of
passing it through as function arguments.

The current logic to assume that files are meant for small random reads
if the first read to them has a non-zero offset assumes the absence of
file headers at the beginning of the file, and/or the absence of magic
number checks.

The new option to specify such files by regular expression pattern will
allow the users to mark such files as random access only, even when
their headers are fetched first.
@siddharthab
Copy link
Author

Please let me know how you would like me to run the integration tests, etc. manually for this PR.

@siddharthab siddharthab marked this pull request as ready for review June 20, 2024 21:31
@siddharthab siddharthab requested a review from a team as a code owner June 20, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant