fix: Fix failing checks #357
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nifflets
force-pushed
the
fix-failing-checks
branch
2 times, most recently
from
3c50907 to
b2c0062
Compare
nifflets
force-pushed
the
fix-failing-checks
branch
from
b2c0062 to
244f651
Compare
nifflets
changed the title
liuyunnnn
reviewed
Dec 30, 2024
| @@ -13,7 +13,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12'] | |||
| python: ['3.9', '3.10', '3.11', '3.12'] | |||
There was a problem hiding this comment.
Are we absolutely sure we should remove these two versions? Seems to me that we still support 3.7 and 3.8 according to https://screenshot.googleplex.com/4TSpCmAE3z63Axt https://screenshot.googleplex.com/4oTVpkPBHbbBw8b
nifflets
force-pushed
the
fix-failing-checks
branch
from
f92fb2e to
a75e77d
Compare
nifflets
force-pushed
the
fix-failing-checks
branch
from
a75e77d to
19e3064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubuntu-latest was updated to 24.04 which caused some of the current checks to fail.
Removed Python 3.7 and 3.8 from the test matrix as these are both past end-of-life now.