Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding integration test for ansible OS coverage #3416

Merged

Conversation

RachaelSTamakloe
Copy link
Collaborator

This PR adds an integration test that installs ansible on various operating systems supported by the Toolkit.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe added the release-chore To not include into release notes label Dec 17, 2024
@RachaelSTamakloe RachaelSTamakloe self-assigned this Dec 17, 2024
@RachaelSTamakloe RachaelSTamakloe force-pushed the ansible-os-test branch 2 times, most recently from 739847b to 759e60e Compare December 18, 2024 15:23
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big step forward. We are documenting the gap in Ansible installer that "sh" does not support "-o pipefail" so there is still some missing failure modes.

@RachaelSTamakloe RachaelSTamakloe merged commit 31195d0 into GoogleCloudPlatform:develop Dec 18, 2024
8 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants