Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uniqueness validation for subnetwork_ranges_list items #3401

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

annuay-google
Copy link
Contributor

@annuay-google annuay-google commented Dec 12, 2024

What?

Validate uniqueness of subnetwork_name field across subnetwork_ranges_list items.

Why?

An earlier PR had introduced a change to support subnetwork_ranges as a list in the interest of better templated blueprints. However, the uniqueness of the map structure was not maintained in the list, and hence would break when multiple items with same subnetwork_name are passed.

Testing

Passed two items with same subnetwork_name in the list, verified validation was triggered.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@annuay-google annuay-google changed the base branch from main to develop December 12, 2024 22:27
@annuay-google annuay-google added the release-chore To not include into release notes label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant