add gke hyperdisk support #3210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengcongdu
added
the
release-module-improvements
ankitkinra
reviewed
Nov 21, 2024
| use: [gke_cluster] | ||
| settings: | ||
| storage_type: Hyperdisk-extreme | ||
| access_mode: ReadWriteOnce |
There was a problem hiding this comment.
Is this be default mode?
There was a problem hiding this comment.
If yes perhaps we can remove this line
There was a problem hiding this comment.
no this is a require parameter, there is no default value set for it
ankitkinra
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Overall LGTM, but two meta comments:
- Can you please update the name of this blueprint to reflect that this hyperdisk is not left around after the blueprint is destroyed. (We are trying to do the same for the parallelstore blueprint)
- Can you please add a comment on this blueprint here https://github.com/GoogleCloudPlatform/cluster-toolkit/blob/e5b89248ba5175e435cc6aec22df0fc4179ad915/examples/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add GKE hyperdisk support to the gke-storage module to handle the creation of storage class and persistent volume claim.
The new module output persistent_volume_claims which can be consumed by the gke-job-template module.
cloud build: https://pantheon.corp.google.com/cloud-build/builds/999405c7-b9fc-4e53-8663-f7128e7534c8?project=hpc-toolkit-dev&e=GkeGettingStartedCloudShellSolutionsLaunch::GkeGettingStartedCloudShellSolutionsEnabled,GkeOnboardingOverviewTabLaunch::GkeOnboardingOverviewTabEnabled&mods=monitoring_api_prod