-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka To Elasticsearch Template #305
base: main
Are you sure you want to change the base?
Kafka To Elasticsearch Template #305
Conversation
@prathapreddy123 is it better to place this inside of google cloud to elasticsearch folder? |
Since kafka is third party product this template should remain outside google cloud to elasticsearch. Separate directory (i.e kafka-to-elasticsearch) should be fine. |
@prathapreddy123 can we get a review please? |
@suyograo - will review by early next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directory Structure looks good. Can you please update PR with actual business logic to avoid merging with empty directories
As discussed earlier, this PR will be reworked to use original ElasticsearchIO from Apache Beam 2.34. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Comment just to remove "stale" label. |
Hi @Cherepushko -- thanks for your contribution here. Unfortunately we ran behind on reviews, and the structure of the project changed a bit. Is there still interest in pursuing this template? We can work together on a plan to resolve conflicts + review the code. |
This is the initial PR for kafka-to-elasticsearch Dataflow template. It contains pom.xml and the empty directories that will be filled in the future pull requests. As a placeholder for the empty folders is used .gitkeep.