Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dependency manager: remove unused code #2011

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fbiville
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 46.17%. Comparing base (cd28d01) to head (4b0d74c).

Files with missing lines Patch % Lines
...oogle/cloud/teleport/v2/neo4j/utils/BeamBlock.java 0.00% 8 Missing ⚠️
...eleport/v2/neo4j/templates/GoogleCloudToNeo4j.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2011      +/-   ##
============================================
+ Coverage     46.16%   46.17%   +0.01%     
+ Complexity     3843     3840       -3     
============================================
  Files           856      856              
  Lines         51010    50984      -26     
  Branches       5365     5364       -1     
============================================
- Hits          23548    23542       -6     
+ Misses        25760    25739      -21     
- Partials       1702     1703       +1     
Components Coverage Δ
spanner-templates 67.88% <ø> (-0.02%) ⬇️
spanner-import-export 65.54% <ø> (-0.06%) ⬇️
spanner-live-forward-migration 76.42% <ø> (ø)
spanner-live-reverse-replication 77.35% <ø> (ø)
spanner-bulk-migration 87.16% <ø> (ø)
Files with missing lines Coverage Δ
...eleport/v2/neo4j/templates/GoogleCloudToNeo4j.java 0.00% <0.00%> (ø)
...oogle/cloud/teleport/v2/neo4j/utils/BeamBlock.java 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@ali-ince ali-ince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice simplification 👍

@fbiville fbiville force-pushed the neo4j/beam-block-cleanup branch from 442c4bd to 4b0d74c Compare December 16, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants