Update terraform modules via plugin #1976
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damondouglas
added
improvement
cleanup
ignore-for-release
and removed
size/XXL
improvement
labels
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1976 +/- ##
============================================
+ Coverage 45.09% 48.31% +3.22%
+ Complexity 3935 1334 -2601
============================================
Files 835 410 -425
Lines 49703 22321 -27382
Branches 5232 2228 -3004
============================================
- Hits 22412 10784 -11628
+ Misses 25625 10866 -14759
+ Partials 1666 671 -995
|
ron-gal
reviewed
Oct 30, 2024
| EOT | ||
| default = "part" | ||
| default = null |
There was a problem hiding this comment.
it's strange that the default is now null, when the comment (and the code, if I remember correctly) have "part" as the default
There was a problem hiding this comment.
The generator is setup assuming either defaulted or optional, not defaulted and optional. I moved this PR to draft to fix this. Thanks for calling this out.
| EOT | ||
| default = "part" | ||
| default = null |
liferoad
reviewed
Nov 5, 2024
| @@ -70,14 +70,14 @@ variable "datastoreWriteNamespace" { | |||
| } | |||
|
|
|||
| variable "datastoreHintNumWorkers" { | |||
| type = string | |||
| description = "Hint for the expected number of workers in the Datastore ramp-up throttling step. Defaults to: 500." | |||
| type = number | |||
There was a problem hiding this comment.
will this be a breaking change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied the following commands to update the repository's Terraform modules:
For the legacy templates:
For the flex templates:
See contributor-docs/code-contributions for more details.