Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DLQ changes for kafka avro #1770

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fozzie15
Copy link
Contributor

@fozzie15 fozzie15 commented Aug 2, 2024

Add DLQ changes for kafka avro to expose the topic, offset, and partition for better visibility into errors.

@fozzie15 fozzie15 force-pushed the kafka_source_offset branch 2 times, most recently from f50ca37 to 2377eb2 Compare August 6, 2024 18:07
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 42.94%. Comparing base (5de403d) to head (6c1461a).
Report is 4 commits behind head on main.

Files Patch % Lines
...teleport/v2/kafka/dlq/BigQueryDeadLetterQueue.java 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1770      +/-   ##
============================================
- Coverage     42.95%   42.94%   -0.01%     
+ Complexity     3391     3390       -1     
============================================
  Files           815      815              
  Lines         47635    47643       +8     
  Branches       5109     5112       +3     
============================================
- Hits          20463    20462       -1     
- Misses        25513    25522       +9     
  Partials       1659     1659              
Components Coverage Δ
spanner-templates 63.77% <ø> (+<0.01%) ⬆️
spanner-import-export 64.40% <ø> (-0.03%) ⬇️
spanner-live-forward-migration 75.17% <ø> (+0.06%) ⬆️
spanner-live-reverse-replication 71.62% <ø> (ø)
spanner-bulk-migration 83.63% <ø> (ø)
Files Coverage Δ
...teleport/v2/kafka/dlq/BigQueryDeadLetterQueue.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@fozzie15 fozzie15 force-pushed the kafka_source_offset branch 2 times, most recently from 6e73e01 to 83ddc88 Compare August 6, 2024 19:05
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 6, 2024
@fozzie15 fozzie15 force-pushed the kafka_source_offset branch from 83ddc88 to cef1777 Compare August 6, 2024 20:12
@pull-request-size pull-request-size bot added size/M and removed size/L labels Aug 6, 2024
@fozzie15 fozzie15 force-pushed the kafka_source_offset branch from cef1777 to c4e4af9 Compare August 6, 2024 20:13
@fozzie15 fozzie15 force-pushed the kafka_source_offset branch from c4e4af9 to 6c1461a Compare August 7, 2024 14:42
@fozzie15 fozzie15 marked this pull request as ready for review August 7, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant