Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommonTemplateJvmInitializerIT #1745

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Jul 24, 2024

Follow up to #1744

Adds IT's to ensure that CommonTemplateJvmInitializer.beforeProcessing() is called by Dataflow worker before executing pipeline.

@Polber Polber self-assigned this Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 42.30%. Comparing base (5be5817) to head (c0434f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1745      +/-   ##
============================================
- Coverage     42.31%   42.30%   -0.01%     
  Complexity     3181     3181              
============================================
  Files           794      796       +2     
  Lines         46244    46257      +13     
  Branches       4951     4950       -1     
============================================
+ Hits          19569    19571       +2     
- Misses        25077    25087      +10     
- Partials       1598     1599       +1     
Components Coverage Δ
spanner-templates 63.69% <ø> (-0.01%) ⬇️
spanner-import-export 64.42% <ø> (-0.03%) ⬇️
spanner-live-forward-migration 74.97% <ø> (ø)
spanner-live-reverse-replication 51.84% <ø> (ø)
spanner-bulk-migration 82.79% <ø> (ø)
Files Coverage Δ
...oud/teleport/plugin/TemplateDefinitionsParser.java 11.53% <0.00%> (+0.42%) ⬆️
...eport/templates/common/JvmInitializerTemplate.java 0.00% <0.00%> (ø)
...oud/teleport/v2/common/JvmInitializerTemplate.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant