Add extra logging for the failure case of the HTTP request. #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1736 +/- ##
============================================
- Coverage 42.32% 42.30% -0.02%
+ Complexity 3182 3179 -3
============================================
Files 794 794
Lines 46244 46248 +4
Branches 4951 4951
============================================
- Hits 19572 19566 -6
- Misses 25074 25082 +8
- Partials 1598 1600 +2
|
fozzie15
force-pushed
the
elasticsearch-logging
branch
from
1bf39d0 to
5f3198b
Compare
fozzie15
force-pushed
the
elasticsearch-logging
branch
from
5f3198b to
bc6dc08
Compare
an2x
requested changes
Jul 22, 2024
| } catch (IOException jsonException) { | ||
| throw new IOException( | ||
| "The response is not a valid JSON: " | ||
| + IOUtils.toString(response.getEntity().getContent(), StandardCharsets.UTF_8)); |
There was a problem hiding this comment.
Can you please add a unit test for this? Make sure an exception is thrown with the HTTP response body in the message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra logging to catch issue where bad responses return HTTP instead of valid JSON.