Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeowners and relevant workflows #1715

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Jul 3, 2024

This will help auto-assign reviewers to core templates infra, with reviews for individual templates being left to author to decide.

@Polber Polber requested a review from damccorm July 3, 2024 18:04
@Polber Polber self-assigned this Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.09%. Comparing base (babf762) to head (b34bd74).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1715      +/-   ##
============================================
+ Coverage     45.04%   45.09%   +0.05%     
- Complexity     3601     3934     +333     
============================================
  Files           835      835              
  Lines         49684    49693       +9     
  Branches       5229     5230       +1     
============================================
+ Hits          22378    22408      +30     
+ Misses        25639    25620      -19     
+ Partials       1667     1665       -2     
Components Coverage Δ
spanner-templates 66.26% <50.00%> (+0.13%) ⬆️
spanner-import-export 64.22% <50.00%> (+0.40%) ⬆️
spanner-live-forward-migration 76.18% <ø> (ø)
spanner-live-reverse-replication 76.54% <ø> (ø)
spanner-bulk-migration 85.55% <ø> (ø)

see 5 files with indirect coverage changes

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This overall LGTM, just had one comment

.github/CODEOWNERS Show resolved Hide resolved
@Polber Polber requested a review from damccorm July 3, 2024 21:40
Signed-off-by: Jeffrey Kinard <[email protected]>
@Polber Polber force-pushed the jkinard/codeowners branch from 35b8c96 to dec5f45 Compare October 23, 2024 16:55
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: Jeffrey Kinard <[email protected]>
@Polber Polber requested a review from damccorm October 24, 2024 15:49
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants