Reverse replication Datatype IT #1603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darshan-sj
requested review from
manitgupta and
VardhanThigle
and removed request for
a team
Merged
darshan-sj
force-pushed
the
rr-datatype-it
branch
from
27260dc to
5c1d35e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1603 +/- ##
============================================
- Coverage 41.29% 41.26% -0.04%
- Complexity 2929 3189 +260
============================================
Files 769 762 -7
Lines 44602 44344 -258
Branches 4770 4750 -20
============================================
- Hits 18418 18298 -120
+ Misses 24636 24497 -139
- Partials 1548 1549 +1
|
darshan-sj
force-pushed
the
rr-datatype-it
branch
3 times, most recently
from
f11932f to
cf476b0
Compare
aksharauke
reviewed
Jun 17, 2024
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class GCSToSourceDbITBase extends TemplateTestBase { |
There was a problem hiding this comment.
Could you also move the other IT tests to be derived from this base class?
| assertThat(row.get("tinyblob_column")) | ||
| .isEqualTo("tinyblob_column_value".getBytes(StandardCharsets.UTF_8)), | ||
| () -> | ||
| assertThat(row.get("blob_column")) |
There was a problem hiding this comment.
Could you add some scenarios for escape characters? There was a bug around this and while it is covered via UT, will be good to add in IT as well. Please refer #1665
If not possible, please add a TODO
darshan-sj
force-pushed
the
rr-datatype-it
branch
from
cf476b0 to
44900ea
Compare
darshan-sj
force-pushed
the
rr-datatype-it
branch
from
47a3ae5 to
b928471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.