Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support conversion of RFC4180 CSV #1514

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kylase
Copy link

@kylase kylase commented May 4, 2024

This PR improves StringToGenericRecordFn, which uses Guava's Splitter, to split a CSV string. This method does not support RFC4180 CSV which could have the comma delimiter within the field value, e.g. 007,"CA,AZ",26.23.

This requires the Apache Commons CSV library to be updated as well as CSVRecord.values method is not public in 1.8.

Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.25%. Comparing base (7189f1d) to head (cd234df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1514      +/-   ##
============================================
- Coverage     41.26%   41.25%   -0.01%     
+ Complexity     2929     2927       -2     
============================================
  Files           763      763              
  Lines         44372    44378       +6     
  Branches       4752     4752              
============================================
  Hits          18308    18308              
- Misses        24521    24525       +4     
- Partials       1543     1545       +2     
Components Coverage Δ
spanner-templates 61.35% <ø> (-0.03%) ⬇️
spanner-import-export 64.38% <ø> (-0.07%) ⬇️
spanner-live-forward-migration 73.88% <ø> (ø)
spanner-live-reverse-replication 49.66% <ø> (ø)
spanner-bulk-migration 82.07% <ø> (ø)
Files Coverage Δ
...le/cloud/teleport/v2/transforms/CsvConverters.java 70.80% <62.50%> (-0.52%) ⬇️

... and 1 file with indirect coverage changes

@kylase kylase force-pushed the fix/support-rfc4180-string-to-genericrecord branch 2 times, most recently from 73fd5f7 to 4ad906d Compare May 11, 2024 06:44
@kylase kylase force-pushed the fix/support-rfc4180-string-to-genericrecord branch from 4ad906d to cd234df Compare June 17, 2024 06:16
Copy link

This pull request has been marked as stale due to 180 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant