Updates to PR353 implemented stop button #362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfo.json, index.njk, and main.js files for various audio worklet demos. Also, updated styles.css.
…out how why cannot start again
… option and module loaded check and removed stop function
hoch
requested changes
May 17, 2024
… one pole filter examples also placed resume in startAudio function
… audio worklet node options which has a weird bug needs fixing
…cause on intial call need to enable sound output
…samples into PR353-update-implemented-stop-button
|
@hoch ok all changes should be good. I tested locally... I am in the process of setting up a live test web page. Does github host that? Also... hopefully i am following protocol with git/github for making these changes |
|
@hoch Just wondering if you can give clarification on a live test page for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated PR 353 with necessary changes for merge. Edited main.js files in:
noise-generator, one-pole-filter, volume-meter, hello-audio-worklet, audio-worklet-node-options
Specifically, I used audioContext.suspend() to allow the user to pause the sound with a stop button. And I added an isModuleLoaded check to avoid redundantly calling addModule. Also added isPlaying to toggle the playing state.