Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Free Queue and WASM Helper Ring Buffer Implementations #354

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MeenuyD
Copy link

@MeenuyD MeenuyD commented Mar 8, 2024

Combine Free Queue and WASM Helper Ring Buffer Implementations

Objective:
The objective of this issue is to combine two different implementations of a ring buffer into a single, cohesive implementation that incorporates the features and advantages of both the Free Queue and WASM Helper approaches.

Description:
Currently, we have two separate implementations of a ring buffer:

Free Queue: This implementation provides a single-producer/single-consumer lock-free FIFO backed by SharedArrayBuffer. It is optimized for managing audio data in a multi-threaded environment.
WASM Helper: This implementation utilizes WebAssembly (WASM) to optimize the ring buffer for single-threaded operation. It is designed to efficiently handle audio data in a single-threaded environment.

#347

Copy link

google-cla bot commented Mar 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Daksh-10
Copy link
Contributor

@MeenuyD you didn't signed the CLA, then only it will be allowed to merged. I am also learning and working on the same project.

@MeenuyD
Copy link
Author

MeenuyD commented Mar 11, 2024

Oh nice I have signed the cla

@hoch
Copy link
Member

hoch commented Mar 11, 2024

IIUC this only adds a new file to the lib directory. I believe other files (the user of this library) will also need to be updated, and the redundant files should be removed.

@MeenuyD
Copy link
Author

MeenuyD commented Mar 11, 2024

Yes I will do it as soon as possible

Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I added some comments.

@hoch hoch added the gsoc24 Google Summer of Code 2024 label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc24 Google Summer of Code 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants