Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update polyfill link #429

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update polyfill link #429

wants to merge 2 commits into from

Conversation

iosh
Copy link

@iosh iosh commented Jun 26, 2024

The usage of polyfill.io is not secure. Please refer to the following link for details : https://sansec.io/research/polyfill-supply-chain-attack

So switch to Fastly. More information can be found here : https://community.fastly.com/t/new-options-for-polyfill-io-users/2540

The usage of polyfill.io is not secure. Please refer to the following link for details : https://sansec.io/research/polyfill-supply-chain-attack

So switch to Fastly. More information can be found here : https://community.fastly.com/t/new-options-for-polyfill-io-users/2540
Copy link

google-cla bot commented Jun 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@niooss-ledger
Copy link

Hello,
[I'm just someone who searched polyfill.io on GitHub Search and found this Pull Request, I'm not related to this project]
Your Pull Request only modifies README.md, but its content seems to be generated from site/src/api.njk:

quicklink/site/src/api.njk

Lines 193 to 197 in cd9ba8e

- Requires `IntersectionObserver` to be supported (see [Can I Use](https://caniuse.com/intersectionobserver)). We recommend conditionally polyfilling this feature with a service like Polyfill.io:
{% endmarkdownConvert %}
{% highlight "html" %}
<script src="https://polyfill.io/v3/polyfill.min.js?features=IntersectionObserver"></script>

I believe this file should also be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants