Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Filter navigation from aggregated report #736

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Jul 3, 2024

Description

This PR enables navigating from a sitemap report insights page to the first site top frame when any filter is selected.

Relevant Technical Choices

Testing Instructions

  • Build CLI and analyze a sitemap.
  • Open the HTML file and click on the Functional category on the sitemap report's landing page.
  • It should open the first site's top frame with a functional filter selected.
  • Now navigate to other sites' different frames, and the filter should persist.
  • Try other filter selections, the navigation, and persistence should persist across the sites and frames.
  • Now analyze a single site and check whether everything works correctly with the same scenarios.

Additional Information:

Screenshot/Screencast

Screen.Recording.2024-07-03.at.12.46.31.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant