fix: don't encode body 2 times #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Mar 25, 2024
Lightning00Blade
force-pushed
the
fix-double-encoding
branch
from
582e143
to
a65170c
Compare
OrKoN
pushed a commit
that referenced
this pull request
Mar 26, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.15](chromium-bidi-v0.5.14...chromium-bidi-v0.5.15) (2024-03-25) ### Features * better support for `network.provideResponse` ([#2065](#2065)) ([99f81fe](99f81fe)) * implement readonly capabilities ([#2070](#2070)) ([a93aa60](a93aa60)) ### Bug Fixes * continue blocking if CDP command fails ([#2068](#2068)) ([43e7f83](43e7f83)) * don't encode body 2 times ([#2069](#2069)) ([aa20457](aa20457)) * throw NoSuchAlertException for prompts ([#2055](#2055)) ([f67f79b](f67f79b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already check the encoding in the
NetworkProcessor, not sure if we should move the logic to theNetworkRequest.#2035