fix: ux behavior on save for anonymous users #453

nikochiko · 2024-08-30T13:31:02Z

should redirect to login page with next=...

Q/A checklist

If you add new dependencies, did you update the lock file?

poetry lock --no-update

Run tests

ulimit -n unlimited && ./scripts/run-tests.sh

Do a self code review of the changes - Read the diff at least twice.
Carefully think about the stuff that might break because of this change - this sounds obvious but it's easy to forget to do "Go to references" on each function you're changing and see if it's used in a way you didn't expect.
The relevant pages still run when you press submit
The API for those pages still work (API tab)
The public API interface doesn't change if you didn't want it to (check API tab > docs page)
Do your UI changes (if applicable) look acceptable on mobile?
Ensure you have not regressed the import time unless you have a good reason to do so.
You can visualize this using tuna:

python3 -X importtime -c 'import server' 2> out.log && tuna out.log

To measure import time for a specific library:

$ time python -c 'import pandas'

________________________________________________________
Executed in    1.15 secs    fish           external
   usr time    2.22 secs   86.00 micros    2.22 secs
   sys time    0.72 secs  613.00 micros    0.72 secs

To reduce import times, import libraries that take a long time inside the functions that use them instead of at the top of the file:

def my_function():
    import pandas as pd
    ...

Legal Boilerplate

Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1208189770838403

devxpy · 2024-09-14T02:35:09Z

curious if this is upto date as per

@SeanBlagsvedt This is the intended UX flow for anonymous users. https://docs.google.com/presentation/d/1P5MKF0jykYPw-G_9SgvKEpu7fjD2v-0gZgLJB4Uw174/edit#slide=id.g2ef5e525406_0_329

daras_ai_v2/base.py

nikochiko · 2024-09-16T08:41:38Z

curious if this is upto date as per

@SeanBlagsvedt This is the intended UX flow for anonymous users. https://docs.google.com/presentation/d/1P5MKF0jykYPw-G_9SgvKEpu7fjD2v-0gZgLJB4Uw174/edit#slide=id.g2ef5e525406_0_329

needs an update, if I remember right

…on workflow page

devxpy · 2024-09-18T13:03:52Z

daras_ai_v2/base.py

+            return
+
+        try:
+            request_state = base64.urlsafe_b64decode(request_state).decode()


Not a good idea. Better to save the state in db but not actually call the celery task.

but for anon users, we won't have their real uid until they login.

are you suggesting that we create a run without a uid, and when the user comes back with SUBMIT_AFTER_LOGIN_Q, we then update the uid and run?

we generate a firebase user as soon as you submit, this should do the same thing

for anon users who come back with an existing account, we would have 2 different uids.

i fixed this case by setting the uid of the unqueued run when user comes back. i added a concurrency check there too so that we don't queue the same run twice.

daras_ai_v2/base.py

…logs in

daras_ai_v2/base.py

This reverts commit 2c43095.

nikochiko · 2024-09-23T13:25:35Z

That sounds like a plausible user flow. I'll make it such that the Copy Link button also saves like the other Save button

this would require more work than I had thought. right now it doesn't trigger a form submit - all javascript.

nikochiko · 2024-09-23T13:39:58Z

fixed the rest, other than the Copy Link fix.

i'll need to release gooey-gui and update version for that.

devxpy · 2024-09-23T15:02:24Z

That sounds like a plausible user flow. I'll make it such that the Copy Link button also saves like the other Save button

this would require more work than I had thought. right now it doesn't trigger a form submit - all javascript.

You can execute js on a python button I believe

if button_pressed:
   gui.js(<js code here>)

…ver first

nikochiko · 2024-09-23T15:34:44Z

done

daras_ai_v2/copy_to_clipboard_button_widget.py

daras_ai_v2/base.py

… the server first" This reverts commit fdee7fc.

…ack to Python caller

…ndering copy link vs share button

devxpy · 2024-10-07T10:04:13Z

I get this error when I try to press the options button as a fresh anonymous user

Traceback (most recent call last):
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/uvicorn/protocols/http/httptools_impl.py", line 404, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in __call__
    return await self.app(scope, receive, send)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/fastapi/applications.py", line 270, in __call__
    await super().__call__(scope, receive, send)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/starlette/applications.py", line 124, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/Users/dev/Projects/dara/ddgai/./server.py", line 107, in middleware
    await app(scope, receive, send)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/starlette/middleware/sessions.py", line 86, in __call__
    await self.app(scope, receive, send_wrapper)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/starlette/middleware/authentication.py", line 48, in __call__
    await self.app(scope, receive, send)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/starlette/middleware/cors.py", line 92, in __call__
    await self.simple_response(scope, receive, send, request_headers=headers)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/starlette/middleware/cors.py", line 147, in simple_response
    await self.app(scope, receive, send)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 75, in __call__
    raise exc
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 64, in __call__
    await self.app(scope, receive, sender)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
    raise e
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/starlette/routing.py", line 680, in __call__
    await route.handle(scope, receive, send)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/starlette/routing.py", line 275, in handle
    await self.app(scope, receive, send)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/starlette/routing.py", line 65, in app
    response = await func(request)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/fastapi/routing.py", line 231, in app
    raw_response = await run_endpoint_function(
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/fastapi/routing.py", line 162, in run_endpoint_function
    return await run_in_threadpool(dependant.call, **values)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/starlette/concurrency.py", line 41, in run_in_threadpool
    return await anyio.to_thread.run_sync(func, *args)
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/anyio/to_thread.py", line 33, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
    return await future
  File "/Users/dev/.virtualenvs/ddgai-b0692ca2/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 807, in run
    result = context.run(func, *args)
  File "/Users/dev/Projects/dara/gooey-gui/py/gooey_gui/core/renderer.py", line 70, in wrapper
    return renderer(
  File "/Users/dev/Projects/dara/gooey-gui/py/gooey_gui/core/renderer.py", line 117, in renderer
    ret = render()
  File "/Users/dev/Projects/dara/ddgai/routers/root.py", line 615, in recipe_or_handle_or_static
    return render_recipe_page(request, parts[0], RecipeTabs.run, example_id)
  File "/Users/dev/Projects/dara/ddgai/routers/root.py", line 691, in render_recipe_page
    page.render()
  File "/Users/dev/Projects/dara/ddgai/./daras_ai_v2/base.py", line 362, in render
    self._render_header()
  File "/Users/dev/Projects/dara/ddgai/./daras_ai_v2/base.py", line 408, in _render_header
    self._render_options_button_with_dialog()
  File "/Users/dev/Projects/dara/ddgai/./daras_ai_v2/base.py", line 473, in _render_options_button_with_dialog
    self._unsaved_options_modal()
  File "/Users/dev/Projects/dara/ddgai/./daras_ai_v2/base.py", line 844, in _unsaved_options_modal
    assert self.request.user
AssertionError

devxpy · 2024-10-07T10:05:32Z

daras_ai_v2/base.py

+        ).update(run_status=STARTING_STATE, uid=self.request.user.uid)
+        if updated_count >= 1:
+            # updated now
+            self.dump_state_to_sr(self._get_validated_state(), self.current_sr)


not sure why this is needed here?

ah, good catch. i think it is leftover from the earlier hack where the state was carried over without creating a saved run. thanks!

nikochiko · 2024-10-07T10:34:26Z

@devxpy fixed both in #481

devxpy · 2024-10-08T09:02:42Z

I can still repro this in prod:

go to /copilot
make an edit to prompt
press save and run
login
run stuck on starting

nikochiko · 2024-10-08T12:19:03Z

fixed in #482 with self.current_sr.refresh_from_db() before queueing.

cause was that we updated current_sr.uid in the database with SavedRun.objects.update(), but not in the ORM object. we should probably get rid of uid from the runner task too. SavedRun.id should be good enough

devxpy · 2024-10-08T14:09:38Z

this also broke rate limits fixed in 7fe01cb

devxpy self-assigned this Sep 14, 2024

devxpy reviewed Sep 14, 2024

View reviewed changes

daras_ai_v2/base.py Outdated Show resolved Hide resolved

devxpy reviewed Sep 14, 2024

View reviewed changes

devxpy assigned nikochiko and unassigned devxpy Sep 14, 2024

Fix save flow for anonymous users

231e9ef

nikochiko force-pushed the save-for-anon-users branch from b5a0a7d to 231e9ef Compare September 16, 2024 18:24

nikochiko added 2 commits September 17, 2024 20:56

feat: add save as new button on update and reorder top-right buttons …

fd0ea16

…on workflow page

Fix text for anon users and version history icon

db69996

nikochiko requested a review from devxpy September 18, 2024 12:48

nikochiko assigned devxpy and unassigned nikochiko Sep 18, 2024

devxpy reviewed Sep 18, 2024

View reviewed changes

daras_ai_v2/base.py Show resolved Hide resolved

devxpy reviewed Sep 18, 2024

View reviewed changes

daras_ai_v2/base.py Outdated Show resolved Hide resolved

devxpy reviewed Sep 18, 2024

View reviewed changes

daras_ai_v2/base.py Outdated Show resolved Hide resolved

devxpy reviewed Sep 18, 2024

View reviewed changes

daras_ai_v2/base.py Outdated Show resolved Hide resolved

devxpy reviewed Sep 18, 2024

View reviewed changes

daras_ai_v2/base.py Outdated Show resolved Hide resolved

devxpy reviewed Sep 18, 2024

View reviewed changes

daras_ai_v2/base.py Outdated Show resolved Hide resolved

devxpy assigned nikochiko and unassigned devxpy Sep 18, 2024

keep unsaved changes to request in an unqueued run - start when user …

c45dcf0

…logs in

nikochiko requested a review from devxpy September 19, 2024 14:20

nikochiko assigned devxpy and unassigned nikochiko Sep 19, 2024

simplify and remove impossible cases

3283ced

devxpy reviewed Sep 19, 2024

View reviewed changes

daras_ai_v2/base.py Show resolved Hide resolved

devxpy reviewed Sep 19, 2024

View reviewed changes

daras_ai_v2/base.py Outdated Show resolved Hide resolved

nikochiko added 4 commits September 23, 2024 18:22

Refactor logic to publish_and_redirect for clarity

5249797

fix buttons for padding

2c43095

Revert "fix buttons for padding"

bf27df5

This reverts commit 2c43095.

fix padding on dialogs

524122b

only show Update & Options button on Run tab

222f5c0

devxpy assigned nikochiko and unassigned devxpy Sep 23, 2024

redo copy_to_clipboard_button to run javascript after hitting the ser…

fdee7fc

…ver first

nikochiko requested a review from devxpy September 23, 2024 15:34

nikochiko assigned devxpy and unassigned nikochiko Sep 23, 2024

devxpy reviewed Oct 3, 2024

View reviewed changes

daras_ai_v2/copy_to_clipboard_button_widget.py Outdated Show resolved Hide resolved

devxpy reviewed Oct 3, 2024

View reviewed changes

daras_ai_v2/base.py Outdated Show resolved Hide resolved

nikochiko added 4 commits October 3, 2024 20:42

Revert "redo copy_to_clipboard_button to run javascript after hitting…

8c0e52e

… the server first" This reverts commit fdee7fc.

replace current_sr_user.uid with current_sr.uid for clarity

0bb1b7f

add new copy_to_clipboard_button_with_return to return some boolean b…

f8497ae

…ack to Python caller

fix: consider case when self.request.user is None as anon user for re…

94ca8b5

…ndering copy link vs share button

nikochiko merged commit b89383a into master Oct 7, 2024
6 checks passed

nikochiko deleted the save-for-anon-users branch October 7, 2024 05:49

devxpy reviewed Oct 7, 2024

View reviewed changes

nikochiko restored the save-for-anon-users branch October 7, 2024 10:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ux behavior on save for anonymous users #453

fix: ux behavior on save for anonymous users #453

nikochiko commented Aug 30, 2024 •

edited

Loading

devxpy commented Sep 14, 2024 •

edited

Loading

nikochiko commented Sep 16, 2024

devxpy Sep 18, 2024

nikochiko Sep 18, 2024

devxpy Sep 18, 2024

nikochiko Sep 19, 2024

nikochiko commented Sep 23, 2024

nikochiko commented Sep 23, 2024

devxpy commented Sep 23, 2024

nikochiko commented Sep 23, 2024

devxpy commented Oct 7, 2024

devxpy Oct 7, 2024

nikochiko Oct 7, 2024

nikochiko commented Oct 7, 2024

devxpy commented Oct 8, 2024

nikochiko commented Oct 8, 2024

devxpy commented Oct 8, 2024

fix: ux behavior on save for anonymous users #453

fix: ux behavior on save for anonymous users #453

Conversation

nikochiko commented Aug 30, 2024 • edited Loading

Q/A checklist

Legal Boilerplate

devxpy commented Sep 14, 2024 • edited Loading

nikochiko commented Sep 16, 2024

devxpy Sep 18, 2024

Choose a reason for hiding this comment

nikochiko Sep 18, 2024

Choose a reason for hiding this comment

devxpy Sep 18, 2024

Choose a reason for hiding this comment

nikochiko Sep 19, 2024

Choose a reason for hiding this comment

nikochiko commented Sep 23, 2024

nikochiko commented Sep 23, 2024

devxpy commented Sep 23, 2024

nikochiko commented Sep 23, 2024

devxpy commented Oct 7, 2024

devxpy Oct 7, 2024

Choose a reason for hiding this comment

nikochiko Oct 7, 2024

Choose a reason for hiding this comment

nikochiko commented Oct 7, 2024

devxpy commented Oct 8, 2024

nikochiko commented Oct 8, 2024

devxpy commented Oct 8, 2024

nikochiko commented Aug 30, 2024 •

edited

Loading

devxpy commented Sep 14, 2024 •

edited

Loading