Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add off hand support for Armor stands #520

Merged
merged 10 commits into from
Jul 8, 2017
Merged

Add off hand support for Armor stands #520

merged 10 commits into from
Jul 8, 2017

Commits on Jul 5, 2017

  1. Add off_hand (shield) support for armorstands 

    also add equipment sounds
closes GlowstoneMC#471
    @Postremus
    Postremus committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    9f24214 View commit details
    Browse the repository at this point in the history

  2. Implement ArmorStand.getEquipment()

    @Postremus
    Postremus committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    85e036b View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2017

  1. Fix some imports 

    some javadocs
fix implementation of setArmorContents
    @Postremus
    Postremus committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    19a0c75 View commit details
    Browse the repository at this point in the history

  2. Implement drop chances

    @Postremus
    Postremus committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    a0279d7 View commit details
    Browse the repository at this point in the history

  3. Store offhand equipment 

    implemented the HandItems, ArmorItems
    @Postremus
    Postremus committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    a569c6c View commit details
    Browse the repository at this point in the history

  4. Actually send the of hand item on armor stand spawn

    @Postremus
    Postremus committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    d105bd9 View commit details
    Browse the repository at this point in the history

  5. revert changes in start.sh

    @Postremus
    Postremus committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    eb89727 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2017

  1. fix imports 

    don't call equipmentmonitor.reset() twice
    @Postremus
    Postremus committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    9fa1a69 View commit details
    Browse the repository at this point in the history

  2. Don't save equipment in armorstandstore 

    we already do that properly in the livingentity

Also don't save the *Items and *Chances Tag for a player, since he can never have these tags
    @Postremus
    Postremus committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    a02ebee View commit details
    Browse the repository at this point in the history

  3. Handle *Items and *Drops Tags with variable sized lists 

    order of the lists musts still be correct, e.g. feet must be before leg

If no Item or dropChance is available, load an empty Itemstack or 1f respectively
    @Postremus
    Postremus committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    f35be0b View commit details
    Browse the repository at this point in the history