Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects french translations #186

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Corrects french translations #186

merged 3 commits into from
Oct 10, 2022

Conversation

Xav83
Copy link
Contributor

@Xav83 Xav83 commented Oct 8, 2022

Hi GoogleContactsEventsNotifier devs 🙂

I am creating this Pull Request to help with the issue #118, during the Hacktoberfest, and help with the french translation.

So, in this Pull Request, I have reviewed the french translations, corrected some strings translation and made some french translations more accurate, in the file code.gs. 🙂

@plainerman
Copy link
Collaborator

Thank you very much for your contribution! If you'd like to contribute more, any help is appreciated 😃 .

@plainerman plainerman merged commit dff3e53 into GioBonvi:master Oct 10, 2022
@Xav83
Copy link
Contributor Author

Xav83 commented Oct 10, 2022

@plainerman, by any chance, can you tag this Pull Request with the hacktoberfest label, in order to make it count in this year Hacktoberfest session ? 🙂

@plainerman plainerman added bug Related to a bug or a critical problem in the code. hacktoberfest This could be a good place to start if you want to contribute to this open source project. translation Anything regarding the translation. and removed bug Related to a bug or a critical problem in the code. labels Oct 10, 2022
@plainerman
Copy link
Collaborator

Is this sufficient?

@Xav83
Copy link
Contributor Author

Xav83 commented Oct 10, 2022

@plainerman , here are the information I have regarding the Hacktoberfest Pull Request requirements:

Screenshot from 2022-10-10 14-27-32

@plainerman plainerman added the hacktoberfest-accepted This PR has been accepted for the hacktoberfest label Oct 10, 2022
@plainerman
Copy link
Collaborator

I added the accepted label, but it says that it takes 7 days to be approved.
If it does not work, you can get back to me.

@Xav83
Copy link
Contributor Author

Xav83 commented Oct 10, 2022

Thanks a lot @plainerman 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This could be a good place to start if you want to contribute to this open source project. hacktoberfest-accepted This PR has been accepted for the hacktoberfest translation Anything regarding the translation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants