Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Data field to searchableColumns to fix the 'Application search' #1843

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Adding Data field to searchableColumns to fix the 'Application search' #1843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23c52e7
Adding Data field to searchableColumns to solve the problem that the …
AbbadiAhmad Jul 16, 2024
4c2c248
Update CHANGELOG.txt
AbbadiAhmad Jul 16, 2024
1361891
Merge pull request #1 from AbbadiAhmad/fixing_application_search
AbbadiAhmad Jul 16, 2024
f4cbf15
Merge branch 'v28.0.00' into v28.0.00
SKuipers Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ v28.0.00
User Admin: updated Manage Users to override required custom fields when manually editing a user

Bug Fixes
Admissions: fixed the search results on the Manage Application page to include json data
Finance: fixed bulk exporting invoice fees for Pending invoices
Form Groups: fixed Year Group Summary list when looking at non-current school years
Timetable: fixed permission checking before displaying user status info in View Timetables list
Expand Down
2 changes: 1 addition & 1 deletion src/Domain/Admissions/AdmissionsApplicationGateway.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class AdmissionsApplicationGateway extends QueryableGateway
private static $tableName = 'gibbonAdmissionsApplication';
private static $primaryKey = 'gibbonAdmissionsApplicationID';

private static $searchableColumns = ['owner', 'gibbonAdmissionsApplicationID'];
private static $searchableColumns = ['owner', 'gibbonAdmissionsApplicationID', 'data'];

/**
* @param QueryCriteria $criteria
Expand Down
Loading