Behaviour: add a new permission so that teachers can only view behaviours created by them #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n view the records created by them
…s are restricted to only view the records created by them
…eachers-can-only-view-behaviours-created-by-them
SKuipers
reviewed
Apr 29, 2024
SKuipers
requested changes
Apr 29, 2024
There was a problem hiding this comment.
Hi Ali, this is looking excellent, with a lot of good thinking and troubleshooting having gone into it. I've added some notes and suggestions, based on reading the code in more detail, but many are just ways to tidy it up some more, rather than logic changes. Thanks again 😄
Co-authored-by: Sandra Kuipers <[email protected]>
Co-authored-by: Sandra Kuipers <[email protected]>
Co-authored-by: Sandra Kuipers <[email protected]>
Co-authored-by: Sandra Kuipers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the _my permission in the behaviour_view and behaviour_view_details page so that teachers and staff are restricted to only view the behaviour records created by them.