Staff: fix approved absences not updating notificationSent status

GibbonEdu · Oct 6, 2023 · 53ec0a9 · 53ec0a9
1 parent 4995b66
commit 53ec0a9
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/modules/Staff/src/CoverageNotificationProcess.php b/modules/Staff/src/CoverageNotificationProcess.php
@@ -135,7 +135,7 @@ public function runNewAbsenceWithCoverageRequest($coverageList)
         $recipients[] = $this->organisationHR;
 
         // Add the absent person, if this coverage request was created by someone else
-        if ($coverage['gibbonPersonID'] != $coverage['gibbonPersonIDStatus'] || $coverage['notificationSent'] == 'N') {
+        if ($coverage['gibbonPersonID'] != $coverage['gibbonPersonIDStatus']) {
             $recipients[] = $coverage['gibbonPersonID'];
         }
 
@@ -154,7 +154,10 @@ public function runNewAbsenceWithCoverageRequest($coverageList)
             foreach ($coverageList as $gibbonStaffCoverageID) {
                 $this->staffCoverageGateway->update($gibbonStaffCoverageID, $data);
             }
-
+
+            $this->staffAbsenceGateway->update($coverage['gibbonStaffAbsenceID'], [
+                'notificationSent' => 'Y',
+            ]);
         }
 
         return $sent;