Skip to content

Commit

Permalink
System: implement URL sanitization in process pages
Browse files Browse the repository at this point in the history
  • Loading branch information
SKuipers committed May 13, 2024
1 parent 49a2b88 commit 2a90579
Show file tree
Hide file tree
Showing 29 changed files with 49 additions and 20 deletions.
3 changes: 3 additions & 0 deletions modules/Admissions/admissions_manage_editProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,13 @@
*/

use Gibbon\Http\Url;
use Gibbon\Data\Validator;
use Gibbon\Domain\Admissions\AdmissionsAccountGateway;

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);

$gibbonAdmissionsAccountID = $_POST['gibbonAdmissionsAccountID'] ?? '';
$search = $_POST['search'] ?? '';

Expand Down
3 changes: 3 additions & 0 deletions modules/Admissions/applicationFormSelectProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,16 @@
*/

use Gibbon\Http\Url;
use Gibbon\Data\Validator;
use Gibbon\Services\Format;
use Gibbon\Comms\EmailTemplate;
use Gibbon\Contracts\Comms\Mailer;
use Gibbon\Domain\Admissions\AdmissionsAccountGateway;

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);

$gibbonFormID = $_POST['gibbonFormID'] ?? '';
$email = $_POST['admissionsLoginEmail'] ?? '';

Expand Down
4 changes: 3 additions & 1 deletion modules/Admissions/applicationFormViewProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,14 @@
*/

use Gibbon\Http\Url;
use Gibbon\Data\Validator;
use Gibbon\Domain\User\UserGateway;
use Gibbon\Domain\Admissions\AdmissionsAccountGateway;
use Gibbon\Domain\User\FamilyGateway;

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);

$gibbonPersonID = $session->get('gibbonPersonID');

$URL = Url::fromModuleRoute('Admissions', 'applicationFormView');
Expand Down
2 changes: 1 addition & 1 deletion modules/Departments/department_editProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST, ['blurb' => 'HTML']);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['blurb' => 'HTML', 'url*' => 'URL']);

//Module includes
include './moduleFunctions.php';
Expand Down
2 changes: 1 addition & 1 deletion modules/Library/library_manage_catalog_addProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

include '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['imageLink' => 'URL', 'fieldLink' => 'URL']);

include './moduleFunctions.php';

Expand Down
2 changes: 1 addition & 1 deletion modules/Library/library_manage_catalog_editProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['imageLink' => 'URL', 'fieldLink' => 'URL']);

include './moduleFunctions.php';

Expand Down
2 changes: 1 addition & 1 deletion modules/Planner/planner_view_full_submitProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['link' => 'URL']);

//Module includes
include './moduleFunctions.php';
Expand Down
2 changes: 1 addition & 1 deletion modules/Planner/planner_view_full_submit_editProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['link' => 'URL']);

//Module includes
include './moduleFunctions.php';
Expand Down
2 changes: 1 addition & 1 deletion modules/Planner/resources_add_ajaxProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['*link' => 'URL']);

$time = time();

Expand Down
2 changes: 1 addition & 1 deletion modules/Planner/resources_manage_addProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

include '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST, ['html' => 'HTML']);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['html' => 'HTML', 'link' => 'URL']);

$URL = $session->get('absoluteURL').'/index.php?q=/modules/'.getModuleName($_POST['address']).'/resources_manage_add.php&search='.$_GET['search'];
$time = time();
Expand Down
2 changes: 1 addition & 1 deletion modules/Planner/resources_manage_editProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST, ['html' => 'HTML']);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['html' => 'HTML', 'link' => 'URL']);

$gibbonResourceID = $_GET['gibbonResourceID'] ?? '';
$URL = $session->get('absoluteURL').'/index.php?q=/modules/'.getModuleName($_POST['address'])."/resources_manage_edit.php&gibbonResourceID=$gibbonResourceID&search=".$_GET['search'];
Expand Down
2 changes: 1 addition & 1 deletion modules/School Admin/behaviourSettingsProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['policyLink' => 'URL']);

$URL = $session->get('absoluteURL').'/index.php?q=/modules/'.getModuleName($_POST['address']).'/behaviourSettings.php';

Expand Down
2 changes: 1 addition & 1 deletion modules/School Admin/formGroup_manage_addProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

include '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['website' => 'URL']);

$gibbonSchoolYearID = $_POST['gibbonSchoolYearID'] ?? '';
$URL = $session->get('absoluteURL').'/index.php?q=/modules/'.getModuleName($_POST['address'])."/formGroup_manage_add.php&gibbonSchoolYearID=$gibbonSchoolYearID";
Expand Down
2 changes: 1 addition & 1 deletion modules/School Admin/formGroup_manage_editProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['website' => 'URL']);

$gibbonSchoolYearID = $_POST['gibbonSchoolYearID'] ?? '';
$gibbonFormGroupID = $_GET['gibbonFormGroupID'] ?? '';
Expand Down
2 changes: 1 addition & 1 deletion modules/Staff/coverage_view_editProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST, ['text' => 'HTML']);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['text' => 'HTML', 'link' => 'URL']);

$gibbonStaffCoverageID = $_POST['gibbonStaffCoverageID'] ?? '';

Expand Down
3 changes: 3 additions & 0 deletions modules/System Admin/formBuilder_addProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,13 @@
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

use Gibbon\Data\Validator;
use Gibbon\Domain\Forms\FormGateway;

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);

$search = $_GET['search'] ?? '';

$URL = $session->get('absoluteURL').'/index.php?q=/modules/System Admin/formBuilder_add.php&search='.$search;
Expand Down
3 changes: 3 additions & 0 deletions modules/System Admin/formBuilder_editConfigProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,13 @@
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

use Gibbon\Data\Validator;
use Gibbon\Domain\Forms\FormGateway;

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST, ['studentDefaultWebsite' => 'URL', 'applicationRefereeLink' => 'URL']);

$gibbonFormID = $_POST['gibbonFormID'] ?? '';

$URL = $session->get('absoluteURL').'/index.php?q=/modules/System Admin/formBuilder_edit.php&gibbonFormID='.$gibbonFormID;
Expand Down
3 changes: 3 additions & 0 deletions modules/System Admin/formBuilder_editProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,13 @@
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

use Gibbon\Data\Validator;
use Gibbon\Domain\Forms\FormGateway;

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);

$gibbonFormID = $_POST['gibbonFormID'] ?? '';

$URL = $session->get('absoluteURL').'/index.php?q=/modules/System Admin/formBuilder_edit.php&gibbonFormID='.$gibbonFormID;
Expand Down
3 changes: 3 additions & 0 deletions modules/System Admin/formBuilder_page_addProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,12 @@
*/

use Gibbon\Domain\Forms\FormPageGateway;
use Gibbon\Data\Validator;

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST, ['introduction' => 'HTML', 'postscript' => 'HTML']);

$gibbonFormID = $_POST['gibbonFormID'] ?? '';
$redirect = $_POST['redirect'] ?? '';

Expand Down
3 changes: 3 additions & 0 deletions modules/System Admin/formBuilder_page_editProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,12 @@
*/

use Gibbon\Domain\Forms\FormPageGateway;
use Gibbon\Data\Validator;

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST, ['introduction' => 'HTML', 'postscript' => 'HTML']);

$gibbonFormID = $_POST['gibbonFormID'] ?? '';
$gibbonFormPageID = $_POST['gibbonFormPageID'] ?? '';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,12 @@

use Gibbon\Domain\Forms\FormFieldGateway;
use Gibbon\Forms\Builder\FormBuilder;
use Gibbon\Data\Validator;

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);

$urlParams = [
'gibbonFormID' => $_POST['gibbonFormID'] ?? '',
'gibbonFormPageID' => $_POST['gibbonFormPageID'] ?? '',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,12 @@
*/

use Gibbon\Domain\Forms\FormFieldGateway;
use Gibbon\Data\Validator;

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);

$urlParams = [
'gibbonFormID' => $_REQUEST['gibbonFormID'] ?? '',
'gibbonFormPageID' => $_REQUEST['gibbonFormPageID'] ?? '',
Expand Down
2 changes: 1 addition & 1 deletion modules/System Admin/systemSettingsProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST, ['indexText' => 'HTML', 'analytics' => 'RAW']);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['indexText' => 'HTML', 'analytics' => 'RAW', 'emailLink' => 'URL', 'webLink' => 'URL']);
include '../../config.php';

// Module includes
Expand Down
2 changes: 1 addition & 1 deletion modules/System Admin/thirdPartySettings_ssoEditProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['authorizeEndpoint' => 'URL', 'tokenEndpoint' => 'URL', 'userEndpoint' => 'URL']);

$sso = $_POST['sso'] ?? '';

Expand Down
2 changes: 1 addition & 1 deletion modules/User Admin/applicationFormSettingsProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST, ['introduction' => 'HTML', 'postscript' => 'HTML']);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['introduction' => 'HTML', 'postscript' => 'HTML', 'applicationFormRefereeLink' => 'URL', 'studentDefaultWebsite' => 'URL']);

$URL = $session->get('absoluteURL').'/index.php?q=/modules/'.getModuleName($_POST['address']).'/applicationFormSettings.php';

Expand Down
2 changes: 1 addition & 1 deletion modules/User Admin/staffApplicationFormSettingsProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST, ['staffApplicationFormIntroduction' => 'HTML', 'staffApplicationFormQuestions' => 'HTML', 'staffApplicationFormPostscript' => 'HTML', 'staffApplicationFormAgreement' => 'HTML', 'staffApplicationFormRequiredDocumentsText' => 'HTML', 'staffApplicationFormNotificationMessage' => 'HTML']);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['staffApplicationFormIntroduction' => 'HTML', 'staffApplicationFormQuestions' => 'HTML', 'staffApplicationFormPostscript' => 'HTML', 'staffApplicationFormAgreement' => 'HTML', 'staffApplicationFormRequiredDocumentsText' => 'HTML', 'staffApplicationFormNotificationMessage' => 'HTML', 'refereeLinks' => 'URL']);

$URL = $session->get('absoluteURL').'/index.php?q=/modules/'.getModuleName($_POST['address']).'/staffApplicationFormSettings.php';

Expand Down
2 changes: 1 addition & 1 deletion modules/User Admin/user_manage_addProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

include '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['website' => 'URL']);

$URL = $session->get('absoluteURL').'/index.php?q=/modules/'.getModuleName($_POST['address']).'/user_manage_add.php&search='.$_GET['search'];

Expand Down
2 changes: 1 addition & 1 deletion modules/User Admin/user_manage_editProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

require_once '../../gibbon.php';

$_POST = $container->get(Validator::class)->sanitize($_POST);
$_POST = $container->get(Validator::class)->sanitize($_POST, ['website' => 'URL']);

//Module includes
include './moduleFunctions.php';
Expand Down
2 changes: 1 addition & 1 deletion preferencesProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

// Sanitize the whole $_POST array
$validator = $container->get(Validator::class);
$_POST = $validator->sanitize($_POST);
$_POST = $validator->sanitize($_POST, ['personalBackground' => 'URL']);

$calendarFeedPersonal = $_POST['calendarFeedPersonal'] ?? '';
$personalBackground = $_POST['personalBackground'] ?? '';
Expand Down

0 comments on commit 2a90579

Please sign in to comment.