Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to include coveralls #62

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Attempt to include coveralls #62

merged 2 commits into from
Jul 23, 2024

Conversation

GiacomoPope
Copy link
Owner

No description provided.

@GiacomoPope
Copy link
Owner Author

Trying to make it work with: https://github.com/coverallsapp/coverage-reporter

@GiacomoPope
Copy link
Owner Author

So I think this is working now: https://coveralls.io/jobs/147503738 but I suppose I need some way to communicate this

@GiacomoPope
Copy link
Owner Author

@tomato42 seeing as this was your suggestion, do you have a "favourite way" to communicate the output from the CLI?

Copy link
Collaborator

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage runs should be part of the normal runs; we use coveralls to combine runs from different environments into one coherent sum total, so we don't want a new Actions job, we want to modify existing ones that test with different python versions

@tomato42
Copy link
Collaborator

one tricky part is that after you create steps to upload the individual job results to coveralls, like so:
https://github.com/tlsfuzzer/python-ecdsa/blob/35c33f2e11e6f95b16cec3fe0eaa5d0e34082b18/.github/workflows/ci.yml#L372-L385

you need to then tell coveralls that all jobs finished and the test run is ready:
https://github.com/tlsfuzzer/python-ecdsa/blob/35c33f2e11e6f95b16cec3fe0eaa5d0e34082b18/.github/workflows/ci.yml#L387-L401

@GiacomoPope
Copy link
Owner Author

I'm finishing for the day now, I might pick this back up later. Feel free to tweak if you want.

@tomato42
Copy link
Collaborator

Fixed it up.

@GiacomoPope
Copy link
Owner Author

Thanks for fixing this for me

@GiacomoPope GiacomoPope merged commit 9842272 into main Jul 23, 2024
12 checks passed
@GiacomoPope GiacomoPope deleted the coveralls branch July 23, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants