Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-171] Refactor call service configs #1256

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

liviu-timar
Copy link
Member

@liviu-timar liviu-timar commented Dec 18, 2024

🎯 Goal

Extend call service configs so we can set runCallServiceInForeground and audioUsage per call type.

👉 Intermediary step to a larger refactoring.

🛠 Implementation details

  • Added new methods and updated existing ones in the CallServiceConfig class to support more flexible configurations, including the ability to update call service settings dynamically.

@liviu-timar liviu-timar force-pushed the extend-call-service-config branch 2 times, most recently from 8043469 to 9748603 Compare December 20, 2024 13:05
@liviu-timar liviu-timar force-pushed the extend-call-service-config branch from 9748603 to e40e3d4 Compare December 20, 2024 13:16
@liviu-timar liviu-timar marked this pull request as ready for review December 20, 2024 13:37
@liviu-timar liviu-timar requested a review from a team as a code owner December 20, 2024 13:37
@liviu-timar
Copy link
Member Author

Marked as Draft because of bug:

The fg service for an accepted incoming call is not starting, even if the settings say to start it. The condition in maybeStartFgService is true, so it reads the config correctly. Tt also calls startForegroundWithServiceType with the correct type. For the outgoing device it works (fg service is started after call is accepted on the other device).

@liviu-timar liviu-timar marked this pull request as draft December 23, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant