Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkFinder update. #145

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

LinkFinder update. #145

wants to merge 4 commits into from

Conversation

mrrobot1o1
Copy link

  • Added functionality to support input from javascript URL link file.
  • DeprecationWarning: ssl warning fix.
  • Updated image for README file.

GerbenJavado
GerbenJavado requested changes Apr 13, 2024
View reviewed changes
Copy link
Owner

@GerbenJavado GerbenJavado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one comment

linkfinder.py
Comment on lines +340 to +343
if os.path.isfile(args.input):
# Read URLs from the file
with open(args.input, 'r') as file:
urls = file.read().splitlines()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to break analyzing JS files locally as the input is not treated as JS but instead split as individual URLs. Prior we would not make any fetch and analyze the content as is. It seems to me analyzing local files is useful so can we revert back to that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GerbenJavado GerbenJavado GerbenJavado requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrrobot1o1 @GerbenJavado