Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade git-commit-id-plugin to 4.9.0 and set useNativeGit to not fail on git worktrees #1300

Merged

Conversation

groldan
Copy link
Member

@groldan groldan commented Aug 8, 2024

jgit does not support git worktrees. Setting the config option <useNativeGit>true</useNativeGit> makes it not fail.

@aaime
Copy link
Member

aaime commented Aug 8, 2024

+1.
It would be nice to have the same configuration across the board. Right now GT is using the same version as GWC, while GeoServer is already on 4.9 but the native git is left as an exercise for the reader, with instructions on how to set up the settings.xml in .m2.... any issue in having it on all the time?

@groldan groldan merged commit 953a80a into GeoWebCache:main Aug 9, 2024
7 checks passed
@groldan groldan deleted the gitcommitid-workaround-for-worktree branch August 9, 2024 18:57
@groldan
Copy link
Member Author

groldan commented Aug 9, 2024

In GeoServer one has to run maven with -Dgit.commit.useNative=true. It'd be nice if it was the default. I'm not sure how many devs use worktrees, but I use them all the time. In any case, whomever is trying to run a build, most probably have native git installed, though I'm not sure if the plugin would fall back to jgit when it's not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants