-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align FileBlobStore with parameter handling practice of S3/Azure #1230
Conversation
3928f71
to
3e75270
Compare
3e75270
to
48ea525
Compare
@smithkm updated so that it also removes the old entries from the previous storage (the layer metadata file). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged. Wondering about a backport. Anyone wants to try this out for a bit? |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.25.x 1.25.x
# Navigate to the new working tree
cd .worktrees/backport-1.25.x
# Create a new branch
git switch --create backport-1230-to-1.25.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick c545cf215fb6c080b3b935fb3b5c710223ff4f84,48ea5259e495533d9b7e9b3e93d0fa3d7e4b969d
# Push it to GitHub
git push --set-upstream origin backport-1230-to-1.25.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.25.x Then, create a pull request where the |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.24.x 1.24.x
# Navigate to the new working tree
cd .worktrees/backport-1.24.x
# Create a new branch
git switch --create backport-1230-to-1.24.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick c545cf215fb6c080b3b935fb3b5c710223ff4f84,48ea5259e495533d9b7e9b3e93d0fa3d7e4b969d
# Push it to GitHub
git push --set-upstream origin backport-1230-to-1.24.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.24.x Then, create a pull request where the |
Should address #880