#1157: Fix for S3BlobStore bulk delete (without listeners) #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaime
reviewed
Oct 2, 2023
| @@ -311,7 +311,7 @@ public KeyVersion apply(long[] loc) { | |||
| @Override | |||
| public boolean delete(final TileRange tileRange) throws StorageException { | |||
|
|
|||
| final String coordsPrefix = keyBuilder.coordinatesPrefix(tileRange, false); | |||
| final String coordsPrefix = keyBuilder.coordinatesPrefix(tileRange, true); | |||
There was a problem hiding this comment.
The change looks legit, not sure why it was working with the listener thought?
Also, can you add a test to cover this issue?
There was a problem hiding this comment.
Hi Andrea, thanks for your review.
It was working with the listener because the coordsPrefix is not used there (see lines 349 and on).
if (listeners.isEmpty()) { <not working, because of coordsPrefix without ending slash> } else { <working, not using coordsPrefix> }
The test exists, but has been ignored by 855ed09.
It effectively fails before the change above, and succeeds after the change.
Maybe you want to try to un-ignore this test?
There was a problem hiding this comment.
You should un-ignore the test with this PR.
This was referenced Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(failing since a133c44, test ignored since 855ed09)