-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
almost there! #138
base: master
Are you sure you want to change the base?
almost there! #138
Conversation
Allow PixelValuesToColorFn to return null values
…ayer-for-leaflet into refactor-2023-winter
If I zoom in far enough to see pixels I get a "polys is not defined" error from https://github.com/GeoTIFF/dufour-peyton-intersection/blob/f38f16ce87d71be685a46f399847ee5cd96f69a1/src/calculate.js#L7 |
Also not sure how to reproduce the behavior of the old getProjector() function (with no arguments) that would return a transform from raster coordinates to (longitude, latitude). |
@jcphill , great catch. I missed that. I'll add in the getProjector function and make sure we have backwards compatibility for those documented functions. Thank you! |
When I have multiple georaster layers loaded at the same time somehow the tile lists are getting crossed. If I change which layer is attached to the map the tiles don't update but if I pan the map then new tiles are added from the new raster. Tiles can even end up drawn on the wrong pane. |
@jcphill , just a quick update. I re-added some of the backwards compatibility, especially focusing on getProjector. It should have the same functionality if you call it without arguments. I published a new next version to NPM, so to-dos:I still need to do the following:
Thank you for all your help testing this new version!!! |
Please see https://github.com/GeoTIFF/georaster-layer-for-leaflet/pull/132/files#r1687367106 for the likely cause of the crossed tile lists issue I reported in January. |
test with