Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

almost there! #138

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

almost there! #138

wants to merge 17 commits into from

Conversation

DanielJDufour
Copy link
Member

@DanielJDufour DanielJDufour commented Dec 1, 2023

test with

npm install georaster-layer-for-leaflet@next

@DanielJDufour DanielJDufour changed the title very much in progress almost there! Jan 24, 2024
@jcphill
Copy link
Contributor

jcphill commented Jan 25, 2024

If I zoom in far enough to see pixels I get a "polys is not defined" error from https://github.com/GeoTIFF/dufour-peyton-intersection/blob/f38f16ce87d71be685a46f399847ee5cd96f69a1/src/calculate.js#L7
Reported as GeoTIFF/dufour-peyton-intersection#4

@jcphill
Copy link
Contributor

jcphill commented Jan 25, 2024

Also not sure how to reproduce the behavior of the old getProjector() function (with no arguments) that would return a transform from raster coordinates to (longitude, latitude).

@DanielJDufour
Copy link
Member Author

@jcphill , great catch. I missed that. I'll add in the getProjector function and make sure we have backwards compatibility for those documented functions. Thank you!

@jcphill
Copy link
Contributor

jcphill commented Jan 26, 2024

When I have multiple georaster layers loaded at the same time somehow the tile lists are getting crossed. If I change which layer is attached to the map the tiles don't update but if I pan the map then new tiles are added from the new raster. Tiles can even end up drawn on the wrong pane.

@DanielJDufour
Copy link
Member Author

DanielJDufour commented Feb 4, 2024

@jcphill , just a quick update. I re-added some of the backwards compatibility, especially focusing on getProjector. It should have the same functionality if you call it without arguments. I published a new next version to NPM, so npm install georaster-layer-for-leaflet@next should install this new version.

to-dos:

I still need to do the following:

  • publish new version of georaster
  • updated/republish all the libs that use dufour-peyton-interesection, fixing "polys is not defined" error.
  • debug issue with multiple georasters and tile lists getting crossed you reported above

Thank you for all your help testing this new version!!!

@jcphill
Copy link
Contributor

jcphill commented Jul 23, 2024

Please see https://github.com/GeoTIFF/georaster-layer-for-leaflet/pull/132/files#r1687367106 for the likely cause of the crossed tile lists issue I reported in January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants