Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change formatting, clearify some explanation, update hyperre, fix issue #21

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

NiekBongers
Copy link

This pull request also includes the fix for the getwd() issue, which Gaby also fixed. I expaned it a bit and included other corrections.

Copy link
Member

@GreatEmerald GreatEmerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to consider; the tutorial needs some more changes.

@@ -33,7 +33,7 @@ code[class^="sourceCode bash"]::before { content: "Bash Source"; }
* Perform simple raster calculations

## Introduction
Raster data is like any image. Although it may portray various properties of objects in the real world, these objects don’t exist as separate objects; rather, they are represented using pixels of various values which are assigned a color.
Raster data is a type of digital data that uses a grid of cells or pixels to represent information. Each cell in the grid represents a different value or attribute, such as pixel, elevation, temperature, or color.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Such as pixel"? Is there a missing word here?

@@ -42,15 +42,15 @@ Today's tutorial is about constructing a simple spatio-temporal analysis using r

![R system architecture graph](figs/geoscripting-system-overview.svg){width=100%}

The overall system architecture is comprised of integrated development environments (IDE), engines, packages, bindings, and libraries. Let's start with the engine, the core program that executes the foundation or crucial tasks of the programming language. The most relevant engines in this course are Python, Google Earth Engine, and R. To interact with the engine, we can either code in the command line directly or we can use an IDE, which provides many tools and features for working with the engine integrated in a single environment. An IDE allows the developer to write code, test it, and debug it all in a single software application. For interacting with the R engine, we can use *Rstudio* or *RKWard* for instance.
The overall system architecture is comprised of integrated development environments (IDE), engines, packages, bindings, and libraries. Let's start with the engine, the core program that executes the foundation or crucial tasks of the programming language. The most relevant engines in this course are Python, Google Earth Engine, and R. To interact with the engine, we can either code in the command line directly or we can use an IDE, which provides many tools and features for working with the engine integrated in a single environment. An IDE enables developers to write, test, and debug code within a single software application. For interacting with the R engine, we can use *Rstudio* or *RKWard* for instance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remove this part altogether. See the new Package and Project management tutorial and the first R tutorial. We will also not have GEE any more. The graph itself may be useful elsewhere, though; thoughts on where it would fit best are welcome!

Feel free to also move content to the previous tutorials if you find that it would be more useful in those.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Then I think it might be useful to move it to the place where most of the architecture and its components are explained which is the package and project management. I think putting it in the summary or just above is a good place!

# If not you can set it using setwd()
getwd()
```{block, type="alert alert-info"}
**Tip**: To set your current working directory in RStudio, go to the menu bar tab; Session → Set Working Directory → To Source File Location
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also covered already in the first R tutorial

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes. I was still an 'issue' from last year, but that thus be removed.

@@ -255,7 +254,7 @@ with NIR and Red being band 4 and 3 of Landsat 7 respectively.
ndvi <- (gewata[[4]] - gewata[[3]]) / (gewata[[4]] + gewata[[3]])
```

The `plot()` function automatically recognises the objects of `terra` classes and returns an appropriate spatial plot.
The `plot()` function automatically recognizes the objects of `terra` classes and returns an appropriate spatial plot.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is US vs UK, and we use the UK English variant. So the original is correct.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty! Then I assume we are consistent and try to use UK instead of US right? So that means, among others, it's also 'colour' instead of 'color'.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I think in this case it might confuse students since libs as matplotlib use 'color'.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to consistently use UK spelling, yes. What libraries use is not very important. They also use truncated and shortened names etc. Interestingly enough, in ggplot2 they have aliases for colour and color so you can use either :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants