mpm_grid_op kernel optimization - coupler.py #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize mpm_grid_op kernel for performance and readability - Precomputed frequently used variables `pos` and `mass_mpm` to eliminate redundant calculations within the kernel. - Used `ti.static` for conditional checks on solver activity (Tool, Rigid, SPH, PBD) to enable Taichi compiler optimizations. - Improved code readability and maintainability while retaining original functionality. - Enhanced coupling efficiency for MPM <-> SPH and MPM <-> PBD by reducing computational overhead in nested loops. This update enhances the overall performance of the `mpm_grid_op` kernel and lays groundwork for further optimizations.
|
Thank you for (such a professional) PR! For prs like this, we would need someone to look into in detail, so please give us a bit time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize mpm_grid_op kernel for performance and readability
posandmass_mpmto eliminate redundant calculations within the kernel.ti.staticfor conditional checks on solver activity (Tool, Rigid, SPH, PBD) to enable Taichi compiler optimizations.This update enhances the overall performance of the
mpm_grid_opkernel and lays groundwork for further optimizations.