Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest demo-data event as prominent example in screenshots #892

Merged

Conversation

carstingaxion
Copy link
Collaborator

@carstingaxion carstingaxion commented Sep 19, 2024

I wanted to do something nice, something visually appealing.
... so I updated the screenshot generator to use the latest demo-data event as prominent example in screenshots ;)

Bildschirmaufzeichnung.vom.19.09.2024.20.55.54.mp4

Description of the Change

Closes #

How to test the Change

Changelog Entry

Changed - Use latest demo-data event as prominent example in screenshots

Credits

Props @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change. ;)
  • All new and existing tests pass.

@mauteri
Copy link
Contributor

mauteri commented Sep 20, 2024

@carstingaxion nice, this good to merge?

@carstingaxion
Copy link
Collaborator Author

carstingaxion commented Sep 20, 2024

@carstingaxion nice, this good to merge?

@mauteri Thanks for looking at this. If ready or not is a little bit a chicken or egg question, if you now this saying.

Simply: No it’s not, because it will reference non-existent images from the main readme.md

Solution: Run the screenshot generator now once, to create the missing images, afterwards merge this PR.

The crux: It would be nice to have the screenshots without the alpha-notice. This will be possible with the next release. Because the screenshot-generator uses the latest release from .org, we should wait until the next is out. This leads to the need for a patch release for only screenshots and readme.

I don’t know.

@mauteri
Copy link
Contributor

mauteri commented Sep 21, 2024

@carstingaxion nice, this good to merge?

@mauteri Thanks for looking at this. If ready or not is a little bit a chicken or egg question, if you now this saying.

Simply: No it’s not, because it will reference non-existent images from the main readme.md

Solution: Run the screenshot generator now once, to create the missing images, afterwards merge this PR.

The crux: It would be nice to have the screenshots without the alpha-notice. This will be possible with the next release. Because the screenshot-generator uses the latest release from .org, we should wait until the next is out. This leads to the need for a patch release for only screenshots and readme.

I don’t know.

Got it, let's chat Monday and figure it out. Thx!

@mauteri mauteri merged commit 552666a into GatherPress:main Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants