Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPRBLN-2281: Mac Mini M2 crash on addon deactivation #631

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

VascoPi
Copy link
Contributor

@VascoPi VascoPi commented Jun 9, 2023

PURPOSE

Mac Mini M2 crash on addon deactivation.
#626

EFFECT OF CHANGE

Fixed addon deactivation crash on Mac Mini M2.

TECHNICAL STEPS

Put apart un/registration for node, socket, and socket interface classes and changed its order.

Put apart un/registration for node, socket, and socket interface classes and changed its order.
@bsavery
Copy link
Contributor

bsavery commented Jun 9, 2023

It's interesting that this would fix the problem, or rather that the different order only effects one platform.

Copy link
Contributor

@bnagirniak bnagirniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

@ARozghon ARozghon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by QA

@bsavery
Copy link
Contributor

bsavery commented Jun 12, 2023

@VascoPi can you explain WHY this fixed it? Not clear to me?

@VascoPi
Copy link
Contributor Author

VascoPi commented Jun 12, 2023

While debugging it was found that utilizing bpy.utils.register_classes_factory's order for given classes causes the error.
Simply changing the unregistering order fixes the issue.

Eventually, I didn't find an accurate explanation for why it happens only at M2. Looks like the blender code doesn't have a special condition for M2 as well.

Also changing Python version to 3.10 while the building process doesn't give any results.

Agree it's strange behavior on M2 because no warnings or errors are observed on other systems using the common bpy.utils.register_classes_factory's order for given classes.

@bsavery bsavery merged commit 36cd6f9 into GPUOpen-LibrariesAndSDKs:master Jun 12, 2023
VascoPi added a commit to VascoPi/RadeonProRenderBlenderAddon that referenced this pull request Aug 2, 2023
…iesAndSDKs#631)

Put apart un/registration for node, socket, and socket interface classes and changed its order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants