Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash while building geometry of multipolygon with zero-node way members #529

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Jun 7, 2024

this bug occurs when the following two conditions are met:

Checklist

@tyrasd tyrasd added the bug Something isn't working as expected label Jun 7, 2024
@tyrasd tyrasd requested a review from rtroilo June 7, 2024 13:37
@tyrasd tyrasd force-pushed the fix-zero-node-multipolygon-member branch from 1e7b4b5 to 1a43e9c Compare June 25, 2024 13:46
…members

this happens when
* a multipolygon refers to a member which at the given timestamp has zero nodes
  - example: https://www.openstreetmap.org/api/0.6/relation/22050/history at `2008-09-30T10:00:52Z` contains https://www.openstreetmap.org/api/0.6/way/25714579/6 which has zero nodes
* the order of the relation members is such that the 0-node member's previous members do not form a closed loop
Copy link
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tyrasd tyrasd merged commit 68e9963 into main Jun 25, 2024
2 checks passed
@tyrasd tyrasd deleted the fix-zero-node-multipolygon-member branch June 25, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants