Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs/rdl/what - sentence addressing non-RDLS fields in datasets #234

Closed
wants to merge 4 commits into from

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Aug 31, 2023

Related issues

closes #56

Description

Merge checklist

  • Update the changelog (style guide)
  • Run ./manage.py pre-commit

If you added, removed or renamed a field:

  • Update the collapse option of the jsonschema directives for dataset, resource, hazard, exposure, vulnerability and loss on reference/schema.md
  • Update the diagrams in reference/schema/md

Having trouble?

See how to resolve check failures.

@odscjen odscjen requested a review from duncandewhurst August 31, 2023 12:04
@duncandewhurst
Copy link
Contributor

Is there also a need to list the individual fields somewhere? If so, I made a suggestion in #149 (comment)

Copy link
Contributor

@matamadio matamadio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit:

RDLS provides general guidance on how the risk datasets should be structured, but it does not have strict rules about which methods to apply or which fields or variables to include. The user ought to make sure that risk datasets follow a logical structure and include all the information necessary to fulfil their intended uses.

@odscjen
Copy link
Contributor Author

odscjen commented Sep 11, 2023

Noticed that this has been superceded by the conversation in #56 so I'm closing this and a new PR can be created once that discussion is concluded.

@odscjen odscjen closed this Sep 11, 2023
@duncandewhurst duncandewhurst deleted the 56-non-rdls-metadata-guidance branch September 21, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Add guidance to docs to instruct users to include key non-metadata in datasets themselves
3 participants