Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGETKF: add function to tune horizontal localization for each observer #437

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

metdyn
Copy link
Collaborator

@metdyn metdyn commented Oct 2, 2024

Description

This PR adds a mechanism to customize horizontal localization (e.g., Gaspari-Cohn) for obs in LGETKF.

  • add a directory /jedi/interfaces/geos_atmosphere/observations/localization
  • each yaml in that directory is used to update localization for the corresponding observer

Dependencies

Impact

@metdyn metdyn requested review from Dooruk and rtodling October 2, 2024 15:18
@metdyn
Copy link
Collaborator Author

metdyn commented Oct 3, 2024

Offline for improvement

@metdyn metdyn closed this Oct 3, 2024
@metdyn metdyn reopened this Nov 6, 2024
@metdyn metdyn removed the request for review from Dooruk November 6, 2024 14:46
@Dooruk
Copy link
Collaborator

Dooruk commented Nov 13, 2024

A quick question, did we confirm having localization in observation YAMLs break the Variational applications?

@metdyn
Copy link
Collaborator Author

metdyn commented Nov 14, 2024

A quick question, did we confirm having localization in observation YAMLs break the Variational applications?
@Dooruk, the added directory jedi/interfaces/geos_atmosphere/observations/localization is used by local ensemble da only. And other modifications are in

M       src/swell/tasks/run_jedi_local_ensemble_da_executable.py
M       src/swell/test/suite_tests/localensembleda-tier1.yaml

This PR does not affect variational runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants