Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hinting and misc changes #417

Merged
merged 26 commits into from
Sep 17, 2024
Merged

Type hinting and misc changes #417

merged 26 commits into from
Sep 17, 2024

Commits on Sep 11, 2024

  1. sles15 is now default platform, added to docs reflecting this and oth… 

    …er additions (GEOS-ESM#407)
    @mranst
    mranst committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b62be29 View commit details
    Browse the repository at this point in the history

  2. swell_static_files_user in config now used in appropriate tasks (GEOS… 

    …-ESM#360)
    @mranst
    mranst committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c2a77f4 View commit details
    Browse the repository at this point in the history

  3. addressed potential error on abort caused by undefined logger call

    @mranst
    mranst committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f9b50f2 View commit details
    Browse the repository at this point in the history

  4. renamed datetime utility to avoid hinting confusion with base package… 

    …, added type hinting (GEOS-ESM#349)
    @mranst
    mranst committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ccb93d6 View commit details
    Browse the repository at this point in the history

  5. type hinting for all python methods (GEOS-ESM#349)

    @mranst
    mranst committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d03c7ed View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. removed unnecessary pass of logger to functions copy_platform_files a… 

    …nd copy_eva_files
    @mranst
    mranst committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    99b5f6d View commit details
    Browse the repository at this point in the history

  2. type hinting in run_geos_executable uses Optional

    @mranst
    mranst committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e277b8a View commit details
    Browse the repository at this point in the history

  3. Hinting changes, Logger properly type hinted, pd.DataFrame now used, … 

    …typing.Optional used where appropriate
    @mranst
    mranst committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5b000ff View commit details
    Browse the repository at this point in the history

  4. Update docs/configuring_cylc.md 

    Co-authored-by: Alexey Shiklomanov <[email protected]>
    @mranst @ashiklom
    mranst and ashiklom authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    dc846ce View commit details
    Browse the repository at this point in the history

  5. added proper hinting for SilentUndefined instance in jinja2.py

    @mranst
    mranst committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ee9852b View commit details
    Browse the repository at this point in the history

  6. proper syntax for linking docs

    @mranst
    mranst committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3fab899 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'refs/remotes/origin/hinting-misc' into … 

    …hinting-misc
    @mranst
    mranst committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    69a7d6d View commit details
    Browse the repository at this point in the history

  8. direct type hinting for FileHandler objects

    @mranst
    mranst committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a8ff454 View commit details
    Browse the repository at this point in the history

  9. added Optional typing where appropriate

    @mranst
    mranst committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a7655d1 View commit details
    Browse the repository at this point in the history

  10. added missing type hint in run_jedi_hofx_executable.py, fixed missing… 

    … typing functions
    @mranst
    mranst committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5f93e20 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'GEOS-ESM:develop' into hinting-misc

    @mranst
    mranst authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2895e5e View commit details
    Browse the repository at this point in the history

  12. more types in hint

    @mranst
    mranst committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    256595d View commit details
    Browse the repository at this point in the history

  13. more precise type hinting

    @mranst
    mranst committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    27ad6ce View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'refs/remotes/origin/hinting-misc' into … 

    …hinting-misc
    @mranst
    mranst committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4ff8fe8 View commit details
    Browse the repository at this point in the history

  15. Resolved code test error

    @mranst
    mranst committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ba8b009 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. more specific type hinting per mypy

    @mranst
    mranst committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e4d5cf1 View commit details
    Browse the repository at this point in the history

  2. corrected logger instance in type hint

    @mranst
    mranst committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    50bd771 View commit details
    Browse the repository at this point in the history

  3. Revised type hinting

    @mranst
    mranst committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    812990d View commit details
    Browse the repository at this point in the history

  4. Revised datetime typing, other refinements

    @mranst
    mranst committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c109c28 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Further revised type hinting

    @mranst
    mranst committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f4903b4 View commit details
    Browse the repository at this point in the history

  2. Update src/swell/utilities/render_jedi_interface_files.py 

    Updated type hint to optional for consistency

Co-authored-by: Alexey Shiklomanov <[email protected]>
    @mranst @ashiklom
    mranst and ashiklom authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5173bcb View commit details
    Browse the repository at this point in the history