-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 4D-Ens-Var option for GEOS-atmosphere #312
Draft
rtodling
wants to merge
33
commits into
develop
Choose a base branch
from
feature/atmos_hyb4denvar
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntly not have this scaling
…nce investigation - results look too close w/ and w/o corr
…, ie initial time of var
I seem to be getting zero feedback in the two issues I refer to above. My plan to bypass the need for those to be resolved is the following:
The two items above are temporary stop gaps to allow for the 4d changes here to move onto develop. I will continue to pursue the answer to the two issues placed in fv3-jedi (above). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This puts the pieces together to allow running hybrid-4D-Ens-Var for the GEOS atmosphere option of SWELL.
In adding this I noticed that the existing variational settings distinguishing only between 3D and 4D were not enough to accommodate options related to 4D-Var vs 4D-Ens-Var. For this reason, the oops interfaces were changed to instead of being "{variational}{window_type}" to "{variational}{cost_type}" - this is way more general and easier to adjust for different options of JEDI.
One or two minor yaml's had to be adjusted on the geos-ocean side of things to fit in the new change ... still need to be tested to make sure nothing is broken.
With respect to the hybrid 4d-ens-var added here, there are still a couple of issues pending:
Dependencies
None
Impact
None