Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4D-Ens-Var option for GEOS-atmosphere #312

Draft
wants to merge 33 commits into
base: develop
Choose a base branch
from

Conversation

rtodling
Copy link
Contributor

@rtodling rtodling commented Mar 18, 2024

Description

This puts the pieces together to allow running hybrid-4D-Ens-Var for the GEOS atmosphere option of SWELL.

In adding this I noticed that the existing variational settings distinguishing only between 3D and 4D were not enough to accommodate options related to 4D-Var vs 4D-Ens-Var. For this reason, the oops interfaces were changed to instead of being "{variational}{window_type}" to "{variational}{cost_type}" - this is way more general and easier to adjust for different options of JEDI.

One or two minor yaml's had to be adjusted on the geos-ocean side of things to fit in the new change ... still need to be tested to make sure nothing is broken.

With respect to the hybrid 4d-ens-var added here, there are still a couple of issues pending:

Dependencies

None

Impact

None

…nce investigation - results look too close w/ and w/o corr
@rtodling rtodling requested review from danholdaway and removed request for danholdaway March 18, 2024 16:22
@rtodling
Copy link
Contributor Author

I seem to be getting zero feedback in the two issues I refer to above. My plan to bypass the need for those to be resolved is the following:

  • have logic in swell (whoever ugly) to handle the 4d-background settings in the yaml
  • have a task added to swell that, in 4d, will look for the analysis, diff them from the background, and convert the corresponding increment to lat-lon - this is what I've been doing offline (outside the context of SWELL).

The two items above are temporary stop gaps to allow for the 4d changes here to move onto develop. I will continue to pursue the answer to the two issues placed in fv3-jedi (above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants