Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to print version info #309

Merged
merged 10 commits into from
Aug 13, 2024

Conversation

pchakraborty
Copy link
Collaborator

@pchakraborty pchakraborty commented Aug 12, 2024

This resolves #306 and #301

pchakraborty and others added 3 commits August 9, 2024 11:31
Merge develop into main, for release (2.0.0)

Many changes

- Added pyproject.toml to aid with pip installation.
- Engineering -- Formatting with Black -- Linting with Pylint -- Dependency management and packaging with Rye
- Added tests to cover more mepo commands
- Added new command update-state to permanently convert mepo1 style state to mepo2
- Converted mepo to a Python project
  -- Added src/mepo/__init__.py
  -- Renamed mepo.d -> src/mepo
  -- Renamed mepo.d/utest -> tests
  -- Renamed doc --> docs
  -- A mepo config file is now called a mepo registry
  -- More code reorganization
- Helper script mepo, used for development, moved to the bin directory. Not removed yet.
- Added README for docs/make_md_docs.py script
- State: pickle format (mepo1 style) to json format (mepo2 style)
  -- If mepo1 style state is detected, print warning and suggest running mepo update-state
* Add brew tap installation instructions

* Add update-state to readme
@pchakraborty pchakraborty requested a review from a team as a code owner August 12, 2024 16:33
mathomp4
mathomp4 previously approved these changes Aug 12, 2024
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that is not how I thought this would be done.

Should we add a unit test for this? I suppose it can't really break.

@pchakraborty
Copy link
Collaborator Author

This way, there is only one version number, in pyproject.toml.

For the develop branch, I suppose I can bump the version number and test against that.

@pchakraborty
Copy link
Collaborator Author

@mathomp4 On second thought, it's probably best to test against the last released version number.

We really shouldn't need to version control lock files. Reusing already existing virtualenv
Generating production lockfile: /home/pchakrab/workspace/code/mepo/develop/requirements.lock
Generating dev lockfile: /home/pchakrab/workspace/code/mepo/develop/requirements-dev.lock
Installing dependencies
Found existing installation: mepo 2.0.0
Uninstalling mepo-2.0.0:
  Successfully uninstalled mepo-2.0.0
Looking in indexes: https://pypi.org/simple/
Obtaining file:///. (from -r /home/pchakrab/tmp/tmpatm5q2yh (line 1))
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Checking if build backend supports build_editable: started
  Checking if build backend supports build_editable: finished with status 'done'
  Getting requirements to build editable: started
  Getting requirements to build editable: finished with status 'done'
  Installing backend dependencies: started
  Installing backend dependencies: finished with status 'done'
  Preparing editable metadata (pyproject.toml): started
  Preparing editable metadata (pyproject.toml): finished with status 'done'
Building wheels for collected packages: mepo
  Building editable for mepo (pyproject.toml): started
  Building editable for mepo (pyproject.toml): finished with status 'done'
  Created wheel for mepo: filename=mepo-2.0.0-py3-none-any.whl size=11085 sha256=758e0b5ae11be1d887f2598e6c04fc09648e00a736ffbe8ae47fbad802e2978f
  Stored in directory: /home/pchakrab/tmp/pip-ephem-wheel-cache-5f1wnqzn/wheels/97/54/f5/d849319cdfa096e074df352654ee2e7c919da8951f090690c6
Successfully built mepo
Installing collected packages: mepo
Successfully installed mepo-2.0.0
Done! will generate them from
requirements.lock Outdated Show resolved Hide resolved
Merging the changes from main brought in the lock files again
@pchakraborty pchakraborty force-pushed the feature/pchakrab/print-version-info branch from 4e48380 to 2a4f9f9 Compare August 12, 2024 22:23
Copy link
Collaborator Author

@pchakraborty pchakraborty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed lock files from version control. Earlier requirements-dev.lock was used by pip to install dependencies. Now we use rye sync which reads toml, and creates the lock files. pyyaml in pyproject.toml remains at >=6.0.1.

@mathomp4 mathomp4 merged commit d4495d3 into develop Aug 13, 2024
15 checks passed
@mathomp4 mathomp4 deleted the feature/pchakrab/print-version-info branch August 13, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants