Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break OuterMetaComponent.F90 into submodule files #2867

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Break OuterMetaComponent.F90 into submodule files #2867

merged 7 commits into from
Jun 13, 2024

Conversation

JulesKouatchou
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

We break the module in the file OuterMetaComponent.F90 into submodules. Each submodule is in its own file that is located in the new folder OuterMetaComponent.

Related Issue

@JulesKouatchou JulesKouatchou added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Jun 11, 2024
@JulesKouatchou JulesKouatchou requested review from a team as code owners June 11, 2024 20:43
tclune
tclune reviewed Jun 12, 2024
View reviewed changes
generic3g/CMakeLists.txt Outdated Show resolved Hide resolved
tclune
tclune reviewed Jun 12, 2024
View reviewed changes
generic3g/CMakeLists.txt Outdated Show resolved Hide resolved
tclune
tclune previously approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please understand the mods I suggested. Accept and see if CI works.

@mathomp4
Copy link
Member

CircleCI was all sorts of broken yesterday due to GEOSgcm v11.6.

@mathomp4
Copy link
Member

Well this is odd. Why is the ADAS one the only failure?

@tclune tclune self-requested a review June 12, 2024 14:19
@GEOS-ESM GEOS-ESM deleted a comment from mathomp4 Jun 12, 2024
tclune
tclune reviewed Jun 12, 2024
View reviewed changes
generic3g/CMakeLists.txt Outdated Show resolved Hide resolved
@tclune tclune merged commit d47dd3a into release/MAPL-v3 Jun 13, 2024
36 checks passed
@tclune tclune deleted the MAPL-v3/smods/generic3g/v5 branch June 13, 2024 13:02
@mathomp4 mathomp4 mentioned this pull request Jun 13, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulesKouatchou @mathomp4 @tclune