Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial update for time_ave_util.x #2852

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

bena-nasa
Copy link
Collaborator

The old time_ave.x always produced right or wrongly, well wrongly with a time increment of 060000 which is the packed integer format in the file in the file. Because of the IO layer in the new time_ave_util.x interprets what is passed as seconds and not a packed integer format, the bad time increment in the output files was not appearing as 060000.

This just makes the files look the same

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) Changelog Skip Skips the Changelog Enforcer labels May 29, 2024
@bena-nasa bena-nasa requested a review from sdrabenh May 29, 2024 18:29
@bena-nasa bena-nasa requested a review from a team as a code owner May 29, 2024 18:29
Copy link

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

2 similar comments
Copy link

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

Copy link

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Jun 13, 2024
Copy link

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

@mathomp4 mathomp4 merged commit ec553bb into R21C Jun 21, 2024
6 of 11 checks passed
@mathomp4 mathomp4 deleted the feature/bmauer/time_ave_r21c branch June 21, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants