Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get metadata for ESMF_FieldBundle for History3G #2841

Merged
merged 29 commits into from
Jun 10, 2024
Merged

Get metadata for ESMF_FieldBundle for History3G #2841

merged 29 commits into from
Jun 10, 2024

Conversation

darianboggs
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

For output, History3G needs metadata for the fields in the ESMF_FieldBundle it uses for output. This PR adds procedures for getting the metadata. Also, it adds a module for keys for ESMF_Info metadata that MAPL3G uses.

Related Issue

#2807

@darianboggs darianboggs added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels May 22, 2024
@darianboggs darianboggs self-assigned this May 22, 2024
@darianboggs darianboggs requested review from a team as code owners May 22, 2024 15:47
tclune
tclune reviewed May 22, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
tclune
tclune reviewed May 22, 2024
View reviewed changes
base/MAPL_ESMF_InfoKeys.F90 Outdated Show resolved Hide resolved
tclune
tclune reviewed May 22, 2024
View reviewed changes
base/MAPL_ESMF_InfoKeys.F90 Outdated Show resolved Hide resolved
tclune
tclune reviewed May 22, 2024
View reviewed changes
base/MAPL_ESMF_InfoKeys.F90 Outdated Show resolved Hide resolved
tclune
tclune previously requested changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You suffer the consequences of me having some time on my hands.

@darianboggs @tclune
Update CHANGELOG.md
ad8c501 
Done

Co-authored-by: Tom Clune <[email protected]>
@darianboggs
Copy link
Contributor Author

Looks like I have a few tests failing to fix.

@darianboggs darianboggs added the Changelog Skip Skips the Changelog Enforcer label May 23, 2024
@tclune tclune self-requested a review May 23, 2024 14:38
@darianboggs
Copy link
Contributor Author

When you get a chance, please review this PR, @tclune. Thanks.

@tclune tclune self-requested a review June 10, 2024 16:04
@darianboggs darianboggs merged commit b89d5b9 into release/MAPL-v3 Jun 10, 2024
36 checks passed
@mathomp4 mathomp4 deleted the feature/wdboggs/get_history_collection_output_info branch August 23, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 left review comments

@tclune tclune tclune approved these changes

Assignees

@darianboggs darianboggs

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darianboggs @mathomp4 @tclune