-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic IO for server #2835
Merged
Merged
Generic IO for server #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bena-nasa
added
🎁 New Feature
This is a new feature
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
📈 MAPL3
MAPL 3 Related
Changelog Skip
Skips the Changelog Enforcer
labels
May 17, 2024
tclune
reviewed
May 20, 2024
tclune
reviewed
May 20, 2024
tclune
reviewed
May 20, 2024
tclune
reviewed
May 20, 2024
tclune
reviewed
May 20, 2024
tclune
reviewed
May 20, 2024
tclune
requested changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
tclune
reviewed
May 20, 2024
tclune
requested changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline
tclune
reviewed
May 20, 2024
tclune
reviewed
May 20, 2024
tclune
reviewed
May 20, 2024
tclune
previously approved these changes
May 20, 2024
tclune
reviewed
May 20, 2024
tclune
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
Changelog Skip
Skips the Changelog Enforcer
📈 MAPL3
MAPL 3 Related
🎁 New Feature
This is a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the server interaction totally generic in the new IO layer for History. Will work for any grid + any ungridded dimensions for any supported type.
Had to make new constructor for array reference. Note the new helper routines are needed and are a bit ugly because this was logic previously stuffed in the grid factory but per @tclune we are trying to avoid a proliferation of methods on the factories. So instead I say, if the grid has 6 tiles I do the messiness needed to the write to our cube format via the server. Still a bit kludgy but I don't see how there wouldn't be a kluge somewhere short of adding the methods that have to do this to the factories or something that is cube specific. This logic is unavoidable somewhere.
At the very least this shows how the actual call to the server can be made to require not a single conditional for rank and type where as the old GriddedIO layer had a if rank==2, if rank==3, and that was it.
This should make writing checkpoints via the server with this layer easy too @pchakraborty
Note I'm also still using a few helper functions in MAPL_Base (MAPL_GridGet and MAPL_GridGetInterior), both are still are needed for basic operations and introspection of grids.
I have confirmed I can write files on the cubed-sphere with this. This just seemed like a good spot to stop and make a PR on a Friday. Obviously more work to do, those helper procedures should be generalized to work with an ESMF Geom, grid specific now, need to work on this. Other details still to implement and units tests needed.
Types of change(s)
Checklist
make tests
)Description
Related Issue