Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug information to fglob function #2830

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

metdyn
Copy link
Contributor

@metdyn metdyn commented May 14, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Added _FAIL to sub. fglob, if pathlen exceeds upper bound of filename length (ESMF_MAXSTR).
I find this could be a potential problem and we need the debug information.

Related Issue

@metdyn metdyn requested a review from a team as a code owner May 14, 2024 16:51
@metdyn metdyn added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label May 14, 2024
tclune
tclune previously approved these changes May 14, 2024
@mathomp4
Copy link
Member

Hmm. If we are using ESMF_MAXSTR (which is 256) anywhere for a path, you might want to find those and change them to ESMF_MAXPATHLEN (which is 1024).

@bena-nasa, @atrayano, and myself can regale you with fun that has happened in the past with paths longer than 256!

@tclune tclune merged commit 8cc8dbd into develop May 20, 2024
36 checks passed
@tclune tclune deleted the feature/ygyu/pathlen_filename branch May 20, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants